Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS targets #59

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Add tvOS targets #59

merged 1 commit into from
Nov 30, 2015

Conversation

neonichu
Copy link
Contributor

This adds a framework target and test target for tvOS.

@neonichu
Copy link
Contributor Author

If this gets merged, it would be great if there could also be a new point release and an update of the podspec on trunk to add tvOS support 👌

@boredzo
Copy link
Owner

boredzo commented Nov 18, 2015

Is there an advantage to having a separate target, vs adding AppleTV as a supported platform to the existing target?

@victor
Copy link

victor commented Nov 18, 2015

I needed this library for an AppleTV project, all I needed to do was add tvOS as a deployment target to my local copy of the podspec.
I'd appreciate it if the project adopted an official podspec in the repo itself, and with tvOS support if possible, so as to have a simpler Podfile.

@neonichu
Copy link
Contributor Author

@boredzo probably not, I didn't know that was possible

@neonichu
Copy link
Contributor Author

I updated the PR so that it adds tvOS support to the existing CocoaTouch targets — much cleaner, thanks for the suggestion 👍

boredzo added a commit that referenced this pull request Nov 30, 2015
Add tvOS support to existing Cocoa Touch targets.
@boredzo boredzo merged commit 590e7cf into boredzo:master Nov 30, 2015
@boredzo
Copy link
Owner

boredzo commented Nov 30, 2015

Thanks for getting this done!

@neonichu neonichu deleted the tvos-support branch November 30, 2015 16:18
@neonichu
Copy link
Contributor Author

neonichu commented Dec 1, 2015

Thanks for merging! Would be great if you could also push a new release to CocoaPods trunk at some point with the additional platform support.

@iGranDav
Copy link

Hi, just want to up this subject to push the tvOS compatible version to CocoaPods trunk please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants