Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h = o * tf.tanh(x=self.c[-1]) in line no. 73 in network.py #3

Closed
leee222 opened this issue Nov 12, 2018 · 1 comment
Closed

h = o * tf.tanh(x=self.c[-1]) in line no. 73 in network.py #3

leee222 opened this issue Nov 12, 2018 · 1 comment

Comments

@leee222
Copy link

leee222 commented Nov 12, 2018

Hi,

In network.py, (line no 73)

h = o*tf.tanh(x=self.c[-1])

is correct? In the paper, h is derived by o and c which have the same timestamp, t.
It should be changed to h = o*tf.tanh(c)?
borelien added a commit that referenced this issue Nov 15, 2018
@borelien
[#3] network: fix hidden layers equation
c6b7a95
@borelien
Copy link
Owner

Yes you are right, good catch!
Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borelien @leee222