This repository has been archived by the owner on May 4, 2021. It is now read-only.
Exif Data Scraped from Filename #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| from __future__ import print_function | |||
| from csv import reader, DictReader | |||
| import exifread as er | |||
| # import exifread as er | |||
|
@kdmurray91 Should be good to go! |
| @@ -236,24 +249,109 @@ def __call__(self, x): | |||
| return None | |||
|
|
|||
|
|
|||
| def resize_img(filename, to_width): | |||
| # Open the Image and get its width | |||
| if(SKIMAGE): | |||
There was a problem hiding this comment.
I'd do
if not SKIMAGE:
warnings.warn('blah')
return
rest
of
the
code
|
@kdmurray91 Made all changes, ready for pull |
| try: | ||
| from skimage.transform import rescale | ||
| from skimage import novice | ||
| import skimage.io as io |
There was a problem hiding this comment.
I'd be keener to do import skimage and use skimage.io.whatever, as there's a stdlib io module.
likewise with novice and rescale above
|
@jbraiuka looks great, few more minor comments. Mostly pedantry. Ping me once those are done and I'll merge. |
|
@kdmurray91 Done. |
|
Perfect. One last change, but I'll fix when I merge on the command line |
kdm9
added a commit
that referenced
this pull request
Jun 10, 2015
|
@jbraiuka all done, nice work man. I'll make a new release and upload to PyPI now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to scrape the date from the filename and write this to the Exif Data of the Image.
Also changed from using ExifRead to pexif (Which has read and write capabilities)