Merge pull request #7855 from ytec-nl/master

Prevent CLI argument issues in scripts/glibc_check.py
borgbackup · Oct 8, 2023 · d4ea884 · d4ea884
2 parents 8fc0944 + 7afa8d4
commit d4ea884
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/scripts/glibc_check.py b/scripts/glibc_check.py
@@ -12,7 +12,6 @@
 import sys
 
 verbose = True
-objdump = "objdump -T %s"
 glibc_re = re.compile(r"GLIBC_([0-9]\.[0-9]+)")
 
 
@@ -32,7 +31,7 @@ def main():
     overall_versions = set()
     for filename in filenames:
         try:
-            output = subprocess.check_output(objdump % filename, shell=True, stderr=subprocess.STDOUT)
+            output = subprocess.check_output(["objdump", "-T", filename], stderr=subprocess.STDOUT)
             output = output.decode()
             versions = {parse_version(match.group(1)) for match in glibc_re.finditer(output)}
             requires_glibc = max(versions)