Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlander options "special effects" #7500

Closed
ThomasWaldmann opened this issue Apr 6, 2023 · 1 comment · Fixed by #7517
Closed

highlander options "special effects" #7500

ThomasWaldmann opened this issue Apr 6, 2023 · 1 comment · Fixed by #7517
Assignees
Labels
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Apr 6, 2023

borg has some cli options with action=Highlander, which raises an error if there is more than one (see also #6269).

E.g. it does not make sense to give --umask more than once (especially not with different values).

But, this error is not raised, if the first of these options happens to use the same value as the default value of the option.

E.g.:

borg --umask 077 --umask 007 rlist --repo ...  # no error (0o077 is the default)
borg --umask 007 --umask 077 rlist --repo ...  # error "there can be only one"
borg --umask 777 --umask 007 rlist --repo ...  # error "there can be only one"
borg --umask 007 --umask 777 rlist --repo ...  # error "there can be only one"
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0rc1 milestone Apr 6, 2023
@jorickert
Copy link
Contributor

I'm working on this

jorickert added a commit to jorickert/borg that referenced this issue Apr 10, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 10, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 10, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 10, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 15, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 15, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
jorickert added a commit to jorickert/borg that referenced this issue Apr 15, 2023
…set once, even if the set value is a default value. Add tests for action=Highlander. See borgbackup#7500 borgbackup#6269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants