Cache sync stuff #1940
Merged
Cache sync stuff #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.26% (diff: 55.55%)@@ master #1940 diff @@
==========================================
Files 20 20
Lines 6764 6765 +1
Methods 0 0
Messages 0 0
Branches 1165 1165
==========================================
- Hits 5568 5565 -3
- Misses 886 889 +3
- Partials 310 311 +1
|
ThomasWaldmann
approved these changes
Dec 9, 2016
| for chunk_id, size, csize in item.chunks: | ||
| chunk_idx.add(chunk_id, 1, size, csize) | ||
| for chunk_id, size, csize in item.get(b'chunks', []): | ||
| chunk_idx.add(chunk_id, 1, size, csize) |
There was a problem hiding this comment.
Does that make a big difference, did you measure it?
There was a problem hiding this comment.
These are both a bit older, this change was looked at previously in #1729 / #235 (comment) . The difference is probably a bit smaller since item now runs w/o the interpreter (well, parts of it...), but I don't expect much (it'd still do the allocations)
| chunk_idx.merge(archive_chunk_idx) | ||
| chunk_idx = chunk_idx or ChunkIndex() | ||
| logger.info('Fetching archive index for %s ...' % archive_name) | ||
| fetch_and_build_idx(archive_id, repository, self.key, chunk_idx) |
There was a problem hiding this comment.
ah, nice, that saves the merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.