New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail how to use macOS/GNOME/KDE keyrings for repo passwords (fixes #392) #2837

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
5 participants
@milkey-mouse
Contributor

milkey-mouse commented Jul 16, 2017

I haven't tested the macOS instructions yet, they were made with a careful reading of the security man pages. I also haven't made the equivalent tutorial for the KDE keyring equivalent (KWallet) yet.

@milkey-mouse

This comment has been minimized.

Show comment
Hide comment
@milkey-mouse

milkey-mouse Jul 16, 2017

Contributor

If anyone reading this has a Mac and is willing to test the Mac instructions that would help (otherwise I'll have to go down to the Apple store and hope none of their Geniuses™ notice me 😉)

Contributor

milkey-mouse commented Jul 16, 2017

If anyone reading this has a Mac and is willing to test the Mac instructions that would help (otherwise I'll have to go down to the Apple store and hope none of their Geniuses™ notice me 😉)

@milkey-mouse milkey-mouse changed the title from [WIP] Detail how to use macOS/GNOME keyrings for repo passwords (fixes #392) to [WIP] Detail how to use macOS/GNOME/KDE keyrings for repo passwords (fixes #392) Jul 17, 2017

Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
@lbeltrame

This comment has been minimized.

Show comment
Hide comment
@lbeltrame

lbeltrame Jul 18, 2017

Note for docs: KWallet users can (assuming it's the KF5 based KWallet) use kwallet-query --read-password <entry name> <wallet name>. Unfortunately at the moment it outputs JSON, so it needs additional processing (via stdout) to extract the password.

lbeltrame commented Jul 18, 2017

Note for docs: KWallet users can (assuming it's the KF5 based KWallet) use kwallet-query --read-password <entry name> <wallet name>. Unfortunately at the moment it outputs JSON, so it needs additional processing (via stdout) to extract the password.

@milkey-mouse

This comment has been minimized.

Show comment
Hide comment
@milkey-mouse

milkey-mouse Jul 19, 2017

Contributor

kwallet-query ended up not working on my Kubuntu test VM(?) but kwalletcli works perfectly and should also have backwards compatibility with KDE 4 and earlier, so I ended up just using that.

Contributor

milkey-mouse commented Jul 19, 2017

kwallet-query ended up not working on my Kubuntu test VM(?) but kwalletcli works perfectly and should also have backwards compatibility with KDE 4 and earlier, so I ended up just using that.

@milkey-mouse milkey-mouse changed the title from [WIP] Detail how to use macOS/GNOME/KDE keyrings for repo passwords (fixes #392) to Detail how to use macOS/GNOME/KDE keyrings for repo passwords (fixes #392) Jul 19, 2017

Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
Show outdated Hide outdated docs/faq.rst Outdated
@milkey-mouse

This comment has been minimized.

Show comment
Hide comment
@milkey-mouse

milkey-mouse Jul 19, 2017

Contributor

collapsed changesets

Contributor

milkey-mouse commented Jul 19, 2017

collapsed changesets

@ThomasWaldmann

This comment has been minimized.

Show comment
Hide comment
@ThomasWaldmann

ThomasWaldmann Jul 19, 2017

Member

@milkey-mouse it is good to collapse some changesets at the end (after all review is finished and at least one core dev approved), but if you do it in the middle of review, you require reviewers to re-read all the stuff just to find out whether the feedback got actually into the changeset. It easier to review incremental diffs, fixup changesets.

Member

ThomasWaldmann commented Jul 19, 2017

@milkey-mouse it is good to collapse some changesets at the end (after all review is finished and at least one core dev approved), but if you do it in the middle of review, you require reviewers to re-read all the stuff just to find out whether the feedback got actually into the changeset. It easier to review incremental diffs, fixup changesets.

@enkore enkore merged commit 77797a2 into borgbackup:master Jul 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enkore

This comment has been minimized.

Show comment
Hide comment
@enkore

enkore Jul 24, 2017

Contributor

Thanks!

Contributor

enkore commented Jul 24, 2017

Thanks!

@milkey-mouse milkey-mouse deleted the milkey-mouse:fix392 branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment