Doc: impact of deleting path/to/repo/nonce #6188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexagonrecursion
added a commit
to hexagonrecursion/borg
that referenced
this pull request
Jan 29, 2022
borgbackup#6188 (comment) > Well, guess one could also use max(list of trusted nonce values). > > The real issue is if you have lost all or some of the trusted > (client side) nonce values and you also have reason to not trust the > server side nonce, because someone might attack you on the server.
Codecov Report
@@ Coverage Diff @@
## master #6188 +/- ##
==========================================
- Coverage 83.23% 83.21% -0.02%
==========================================
Files 38 38
Lines 10387 10387
Branches 2039 2039
==========================================
- Hits 8646 8644 -2
- Misses 1233 1234 +1
- Partials 508 509 +1
Continue to review full report at Codecov.
|
|
restarting CI. I hope it's green this time |
ThomasWaldmann
approved these changes
Feb 4, 2022
|
Hmm, could you do a |
I am about to add documentation for this feature. Per the "If you liked it, you should have put a CI test on it" rule I am adding tests to detect if the feature regresses (causing a discrepancy between the docs and the real behavior).
borgbackup#6188 (comment) > Well, guess one could also use max(list of trusted nonce values). > > The real issue is if you have lost all or some of the trusted > (client side) nonce values and you also have reason to not trust the > server side nonce, because someone might attack you on the server.
> do we maybe also want to mention the specific path where the local > nonce is kept?
hexagonrecursion
force-pushed
the
nonce
branch
from
f032e04
to
6bc1f48
Compare
|
Done |
|
Thanks! |
hexagonrecursion
added a commit
to hexagonrecursion/borg
that referenced
this pull request
Feb 7, 2022
borgbackup#6188 (comment) > Well, guess one could also use max(list of trusted nonce values). > > The real issue is if you have lost all or some of the trusted > (client side) nonce values and you also have reason to not trust the > server side nonce, because someone might attack you on the server.
|
Backport is merged. Please remove the backport/1.1-maint label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5858
In addition to explaining the consequences of deleting path/to/repo/nonce I have added tests to make sure that what the docs say is actually true.