Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locked requirements (master) #6235

Merged

Conversation

ThomasWaldmann
Copy link
Member

No description provided.

@ThomasWaldmann ThomasWaldmann changed the title temp: try locked requirements add locked requirements (master) Feb 4, 2022
@ThomasWaldmann ThomasWaldmann force-pushed the requirements-locked-master branch 4 times, most recently from 7445273 to 17b6812 Compare February 4, 2022 19:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #6235 (8363169) into master (9f311ab) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6235      +/-   ##
==========================================
- Coverage   83.26%   83.21%   -0.05%     
==========================================
  Files          38       38              
  Lines       10385    10387       +2     
  Branches     2038     2039       +1     
==========================================
- Hits         8647     8644       -3     
- Misses       1232     1234       +2     
- Partials      506      509       +3     
Impacted Files Coverage Δ
src/borg/crypto/key.py 86.30% <0.00%> (-0.30%) ⬇️
src/borg/helpers/parseformat.py 89.70% <0.00%> (-0.17%) ⬇️
src/borg/archive.py 82.06% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f311ab...8363169. Read the comment docs.

@ThomasWaldmann
Copy link
Member Author

this need special care when backporting:

  • try the locked requirements on github ci first (by placing them in development.txt)
  • also, compare with the previous stuff, not all requirements from master might apply

@ThomasWaldmann ThomasWaldmann marked this pull request as ready for review February 4, 2022 20:08
@ThomasWaldmann ThomasWaldmann merged commit b8ad7cd into borgbackup:master Feb 4, 2022
@ThomasWaldmann ThomasWaldmann deleted the requirements-locked-master branch February 4, 2022 21:32
@hexagonrecursion
Copy link
Contributor

I'll backport this today

@ThomasWaldmann
Copy link
Member Author

see also #6246.

hexagonrecursion added a commit to hexagonrecursion/borg that referenced this pull request Feb 5, 2022
borgbackup#6235 (comment)
> try the locked requirements on github ci first (by placing them in development.txt)
@hexagonrecursion
Copy link
Contributor

Backport is merged. Please remove the backport/1.1-maint label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants