-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argon2 the first part: Implement key derivation (was: part 0) #6468
Argon2 the first part: Implement key derivation (was: part 0) #6468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6468 +/- ##
==========================================
- Coverage 82.70% 82.68% -0.02%
==========================================
Files 39 39
Lines 10519 10525 +6
Branches 2076 2076
==========================================
+ Hits 8700 8703 +3
- Misses 1311 1314 +3
Partials 508 508
Continue to review full report at Codecov.
|
3fce6f7
to
a204355
Compare
https://www.ietf.org/archive/id/draft-irtf-cfrg-argon2-03.txt
|
ci.appveyor.com:
|
seems like they have issues at appveyor (but we can just ignore that for now). |
Requested during review: borgbackup#6468 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
OK, ready for merging? |
I'ld squash the commits together... |
ready |
This is the first part of #747. I have added a method to
helpers.passphrase.Passphrase
to derive keys via argon2.I have chosen to add a new method instead of changing
helpers.passphrase.Passphrase.kdf because
:PS. After reading the code I have reversed my original decision and started implementing this bottom-up. I'll do decrypt_key_file next
PPS. Sorry for the delay. I am back in your galaxy and ready to work on this today.