Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argon2 the third part: borg key change-algorithm #6549

Merged
merged 3 commits into from
Apr 9, 2022

Conversation

hexagonrecursion
Copy link
Contributor

As promised I have implemented key change-algorithm.

My plan after this is merged:

  • The fourth part: add an argon2 benchmark to borg benchmark cpu
  • The fifth part: changelog and usage docs.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #6549 (5a31c89) into master (1e213e9) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #6549      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.01%     
==========================================
  Files          39       39              
  Lines       10574    10586      +12     
  Branches     2069     2070       +1     
==========================================
+ Hits         8785     8794       +9     
- Misses       1288     1290       +2     
- Partials      501      502       +1     
Impacted Files Coverage Δ
src/borg/archiver.py 78.41% <75.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e213e9...5a31c89. Read the comment docs.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nitpicks, rest LGTM.

src/borg/archiver.py Outdated Show resolved Hide resolved
src/borg/archiver.py Outdated Show resolved Hide resolved
Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing

@ThomasWaldmann
Copy link
Member

btw, there is already an argon2 / kdf cpu benchmark, but it should be updated so both benchmarks use the same parameters as borg in production.

@hexagonrecursion
Copy link
Contributor Author

one last thing

What "last thing"?

@ThomasWaldmann ThomasWaldmann merged commit d386b03 into borgbackup:master Apr 9, 2022
@ThomasWaldmann
Copy link
Member

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants