-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argon2 the third part: borg key change-algorithm
#6549
Argon2 the third part: borg key change-algorithm
#6549
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6549 +/- ##
==========================================
- Coverage 83.08% 83.07% -0.01%
==========================================
Files 39 39
Lines 10574 10586 +12
Branches 2069 2070 +1
==========================================
+ Hits 8785 8794 +9
- Misses 1288 1290 +2
- Partials 501 502 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor nitpicks, rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing
btw, there is already an argon2 / kdf cpu benchmark, but it should be updated so both benchmarks use the same parameters as borg in production. |
What "last thing"? |
Thanks, merged! |
As promised I have implemented
key change-algorithm
.My plan after this is merged: