Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg.remote: remove legacy #7603

Merged
merged 5 commits into from May 24, 2023

Conversation

ThomasWaldmann
Copy link
Member

No description provided.

rpc format:
ancient borg used tuples in the rpc protocol,
but recent ones use easier-to-work-with dicts.

version info:
we expect dicts with server/client version now.
exception infos:
ancient borg gave only limited infos about exceptions,
but recent ones give more.
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #7603 (2331341) into master (5e4202e) will increase coverage by 0.19%.
The diff coverage is 83.33%.

❗ Current head 2331341 differs from pull request most recent head 90c6b7f. Consider uploading reports for the commit 90c6b7f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
+ Coverage   83.73%   83.93%   +0.19%     
==========================================
  Files          66       66              
  Lines       11789    11730      -59     
  Branches     2152     2131      -21     
==========================================
- Hits         9872     9845      -27     
+ Misses       1341     1321      -20     
+ Partials      576      564      -12     
Impacted Files Coverage Δ
src/borg/remote.py 85.26% <80.76%> (+4.12%) ⬆️
src/borg/archiver/__init__.py 85.48% <100.00%> (ø)
src/borg/logger.py 68.42% <100.00%> (-1.33%) ⬇️

... and 1 file with indirect coverage changes

log output:

always expect json, remove $LOG format support.

we keep limited support for unstructured format also,
just not to lose anything from remote stderr.
in the sysinfo function, there is a way to suppress
all sysinfo output via an env var and just return an
empty string.

so we can expect it is always in unpacked, but it
might be the empty string.
@ThomasWaldmann ThomasWaldmann merged commit fbb6014 into borgbackup:master May 24, 2023
11 checks passed
@ThomasWaldmann ThomasWaldmann deleted the remove-legacy branch May 24, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants