Make Repository a context manager, use decorators for wrapping withs #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Remote)Repository.close() is not a public API anymore, but a private API. It shall not be used from within other classes than Repository or it's tests. The proper way is to use a context manager now. However, for RPC/Remote compatibility with Borg 1.0 it is kept and unchanged. Repositories are not opened by __init__ now anymore, it is done by binding it to a context manager. (This SHOULD be compatible both ways with remote, since opening the repo is handled by a RepositoryServer method) Decorators @with_repository() and @with_archive simplify context manager handling and remove unnecessary indentation. Backported to 1.0-maint
Current coverage is
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from #777 to 1.0-maint