Skip to content

Commit

Permalink
Prevent exception while running BorgVersionJob with unexpected lines …
Browse files Browse the repository at this point in the history
…on stderr

The borg job logic expects the `profile_name` key to be unconditionally present in the params if any data is received on stderr. This causes the BorgVersionJob (which didn’t set this param) to fail if any unexpected output – such as LD_PRELOAD warnings – in generated while running `borg --version`. This in turn causes Vorta to silently (other than an unrelated looking exception in the console output) fall back to assuming borg 1.1.0 as the borg version.
  • Loading branch information
ntninja authored and m3nu committed Apr 8, 2024
1 parent 3268bf1 commit 9f1f75c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/vorta/borg/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def prepare(cls):
return ret

ret['cmd'] = ['borg', '--version']
ret['profile_name'] = 'default'
ret['ok'] = True
return ret

Expand Down

0 comments on commit 9f1f75c

Please sign in to comment.