Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule time divided by 24 #106

Closed
amiroslaw opened this issue Dec 28, 2018 · 1 comment
Closed

Schedule time divided by 24 #106

amiroslaw opened this issue Dec 28, 2018 · 1 comment

Comments

@amiroslaw
Copy link

vorta 0.6.3-1

When you fixed the bug #101, you made new one.
Now if a user change backup schedule to a number which is divided by 24, he will get:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/vorta/views/schedule_tab.py", line 112, in on_scheduler_apply
    self.app.scheduler.reload()
  File "/usr/lib/python3.7/site-packages/vorta/scheduler.py", line 33, in reload
    minute=profile.schedule_interval_minutes)
  File "/usr/lib/python3.7/site-packages/apscheduler/triggers/cron/__init__.py", line 82, in __init__
    field = field_class(field_name, exprs, is_default)
  File "/usr/lib/python3.7/site-packages/apscheduler/triggers/cron/fields.py", line 33, in __init__
    self.compile_expressions(exprs)
  File "/usr/lib/python3.7/site-packages/apscheduler/triggers/cron/fields.py", line 58, in compile_expressions
    self.compile_expression(expr)
  File "/usr/lib/python3.7/site-packages/apscheduler/triggers/cron/fields.py", line 64, in compile_expression
    compiled_expr = compiler(**match.groupdict())
  File "/usr/lib/python3.7/site-packages/apscheduler/triggers/cron/expressions.py", line 22, in __init__
    raise ValueError('Increment must be higher than 0')
ValueError: Increment must be higher than 0
@m3nu
Copy link
Contributor

m3nu commented Dec 29, 2018

Already fixed yesterday for v0.6.4. #104

This solution isn't great either, so I may change the interface a bit to support entering days at a later time.

@m3nu m3nu closed this as completed Dec 29, 2018
m3nu added a commit that referenced this issue Jan 6, 2019
* Add pre/post-backup command setting. Fixes #109
* Bug fixes for #111 and #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants