Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception dialog with copy & paste or direct error reporting #1861

Open
ThomasWaldmann opened this issue Nov 30, 2023 · 12 comments · May be fixed by #1977
Open

Improved exception dialog with copy & paste or direct error reporting #1861

ThomasWaldmann opened this issue Nov 30, 2023 · 12 comments · May be fixed by #1977
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function

Comments

@ThomasWaldmann
Copy link
Collaborator

Description

When Vorta crashed due to a python exception, one gets a dialogue box telling that one shall report the issue.

Problems:

  • copy and paste does not work from there, so one has to manually type the whole stuff one is seeing in that box.
  • the dialogue box contents are rather ugly / badly formatted

Environment

  • OS: macOS Ventura
  • Vorta version: 0.9.1beta3
  • Installed from: .dmg binary download
  • Borg version: 1.2.6
@ThomasWaldmann
Copy link
Collaborator Author

It can also be found in vorta.log:

2023-11-30 17:53:38,412 - root - CRITICAL - Uncaught exception, file a report at https://github.com/borgbase/vorta/issues/new/choose
Traceback (most recent call last):
  File "views/exclude_dialog.py", line 266, in custom_pattern_editing_finished
AttributeError: 'NoneType' object has no attribute 'text'

Wondering if including the full traceback would make that more useful?

@m3nu
Copy link
Contributor

m3nu commented Dec 1, 2023

Yes, this dialog could be nice. It's dealt with centrally, so should be simple enough to reformat it.

IIRC this was an idea for GSoC, but wasn't picked up in the end.

@m3nu m3nu changed the title no copy and paste from exception dialogue box Improved exception dialog with copy & paste or direct error reporting Dec 1, 2023
@m3nu
Copy link
Contributor

m3nu commented Dec 1, 2023

I can't find an open issue for this, so let's track it here. This is what I imagined for errors. Maybe this can be POSTed to a Github issue from the dialog?

crashreport1

@m3nu m3nu added type:enhancement Improvement of an existing function good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it labels Dec 1, 2023
@rai-ankur
Copy link

@ThomasWaldmann @m3nu could you please assign this issue to me , would like to work on this.

@ThomasWaldmann
Copy link
Collaborator Author

@rai-ankur Assigned - thanks for helping!

@real-yfprojects
Copy link
Collaborator

@rai-ankur Please share mockups before implementing the GUI. Also if you run into problems, feel free to ask.

@AdwaitSalankar
Copy link
Contributor

AdwaitSalankar commented Mar 16, 2024

@ThomasWaldmann @m3nu Can I work on this? I think the GUI can look like this.
Screenshot from 2024-03-17 21-57-08

@shivansh02
Copy link
Collaborator

Looks good! I would suggest adding a copy button though.

@ThomasWaldmann
Copy link
Collaborator Author

@rai-ankur You don't work on this any more, right?

@ThomasWaldmann
Copy link
Collaborator Author

@AdwaitSalankar Personally, I would rather have copy&paste than "send this report directly to Github" (and any complexity relating to the latter).

@AdwaitSalankar
Copy link
Contributor

Agreed, This would simplify things.
Does this look good?
Screenshot from 2024-03-19 00-42-59
The GitHub link will direct to https://github.com/borgbase/vorta/issues/new/choose

@ThomasWaldmann
Copy link
Collaborator Author

I think the link should go to .../issues and it should also tell "Please only open new issues after checking if this issue was not already reported."

@shivansh02 shivansh02 linked a pull request Mar 31, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants