-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Exception Dialog with Copy Paste #1977
Improved Exception Dialog with Copy Paste #1977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement over the error dialog that we have currently, thanks!
src/vorta/views/exception_dialog.py
Outdated
def get_os_details(): | ||
uname_result = platform.uname() | ||
os_details = f"OS: {uname_result.system}\n" | ||
os_details += f"Node Name: {uname_result.node}\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a format string for the datetime, so it doesn't put the subsecond decimals there.
About the "Log:":
- that's a traceback and guess you did not get it from the log, but directly within python.
- but, vorta (and also borg) do write a log, which might have some additional interesting infos, which you do not yet include. maybe a link that opens the correct log file so that the user can easily c&p stuff from there would be useful here.
I suppose |
@m3nu @ThomasWaldmann Can you please take a look? |
This can be done once this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
src/vorta/assets/icons/alert.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you source this image from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wikipedia commons: https://en.m.wikipedia.org/wiki/File:Warning.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly the image file is released into the public domain and we are free to relicence it?
We should also consider using the corresponding fork awesome icon for consistency with the other icons in the GUI.
Needs rebase and an icon from the sources we usually use https://vorta.borgbase.com/contributing/#icons |
20f68fb
to
422973f
Compare
@m3nu Done, and the checks are passing as well. Can we merge this? |
422973f
to
7ce0dfd
Compare
7ce0dfd
to
df196d8
Compare
Description
Exception dialog improvements:
-better UI
-copy paste functionality
-detailed error with system information
-report to github functionality
Related Issue
Fixes #1861
Motivation and Context
Exception Dialog currently has bad UI and no copy paste functionality.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.