Accented chars don't show in Extract dialog when using packaged binary

[Docteur-ito]

Hello,
I have a problem when i try to extract a backup.
The source path contains the character é
/Users/.../fond d'écran

When extracting, it says :
WARNING : Include pattern 'Users/.../fond d'?ecran' never matched.
The folder is not restored.

I tried to find any Unicode encoding parameter in Vorta with no success

macOS 10.14.3, Vorta 0.6.10, OS language french

Vorta log :

2019-03-04 00:02:15,728 - vorta.borg.borg_thread - INFO - Running command /var/folders/n6/g14277n95x9c127w5lq2dshr0000gn/T/_MEIX4A01F/bin/borg list --info --log-json --format {size:8d}{TAB}{mtime}{TAB}{path}{NL} pi@10.0.0.202:/home/pi/Sauvegarde::macbook-pro-dito.home-default-2019-03-04T00:01:45
2019-03-04 00:02:33,598 - vorta.borg.borg_thread - INFO - Running command /var/folders/n6/g14277n95x9c127w5lq2dshr0000gn/T/_MEIX4A01F/bin/borg extract --list --info --log-json pi@10.0.0.202:/home/pi/Sauvegarde::macbook-pro-dito.home-default-2019-03-04T00:01:45 Users/ito/Documents/Fond d'?cran/.Snow Server.jpg.icloud Users/ito/Documents/Fond d'?cran/widescreen 2.png Users/ito/Documents/Fond d'?cran/RBaP.gif Users/ito/Documents/Fond d'?cran/widescreen.jpg Users/ito/Documents/Fond d'?cran/PixelArt.png Users/ito/Documents/Fond d'?cran/987-5-8.jpg Users/ito/Documents/Fond d'?cran/Diaboliques.png Users/ito/Documents/Fond d'?cran/leopard-server-wallpaper.jpg Users/ito/Documents/Fond d'?cran/Aurora.jpg Users/ito/Documents/Fond d'?cran
2019-03-04 00:02:37,048 - vorta.borg.borg_thread - WARNING - Include pattern 'Users/ito/Documents/Fond d'?cran/.Snow Server.jpg.icloud' never matched.
2019-03-04 00:02:37,049 - vorta.borg.borg_thread - WARNING - Include pattern 'Users/ito/Documents/Fond d'?cran/widescreen 2.png' never matched.

[m3nu]

I've seen the ?? char used for accented chars used in the extract dialog before. Not always but sometimes. I suspect there is a Unicode issue somewhere between getting the output and displaying it.

[ThomasWaldmann]

Might be related to the different unicode representation macOS uses for accented chars.

[m3nu]

Here is a funny thing: When I run Vorta as Python app, the accented chars work fine, when I run it as fat binary, they are displayed as ?. So I'm assuming Pyinstaller strips out some modules required for encoding. Maybe they can be included explicitly.

[ThomasWaldmann]

Maybe add some debug output showing the fs encoding and the env vars (so one can see the locale settings as seen by the vorta code inside pyinstaller).

[m3nu]

Added a possible fix in #249. Was indeed related to Pyinstaller's encoding. Maybe you can test this DMG, @Docteur-ito and see if it fixes the issue, while still having French translations: https://files.qmax.us/vorta-0.6.16.dmg

pyinstaller/pyinstaller#3592 (comment)

[ThomasWaldmann]

Considering borg (cli) also needs to process non-ascii strings, do this somehow also affect the borg fat binary on OS X?

[m3nu]

No. Couldn't reproduce it with Borg directly in any way. This issue arises from the fact that Qt expects some language-related variables, like LC_CTYPE=C LANG=ASCII. I tried breaking Borg directly with it, but I guess it doesn't use those vars. So all good.