Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert on missing Borg binary instead of showing placeholder version number #333

Closed
goebbe opened this issue Jul 22, 2019 · 2 comments
Closed

Alert on missing Borg binary instead of showing placeholder version number #333

goebbe opened this issue Jul 22, 2019 · 2 comments
Assignees
@m3nu
Labels
type:enhancement Improvement of an existing function

Comments

@goebbe
Copy link

goebbe commented Jul 22, 2019 •
edited
Loading

I installed Vorta with the pip3 method on GalliumOS (Linux OS, GUI:Xfce) and had the following minor issue:
Since I did not install borg before, Vorta complained nicely, when I tried to create a test-repository.
However, in Vorta>Misc the information about the borg Version was wrong, since it showed:
Borg Version: 1.1.10
However, borg was not installed at all.

Expected behaviour:
If borg is not available Vorta should show this in the Misc tab. Something like:
Borg Version: not installed

Desktop (please complete the following information):

  • Linux Gallium OS 3.0
    kernel 4.1.18-galliumos GUI: Xfce
@m3nu
Copy link
Contributor

m3nu commented Jul 22, 2019

I think you're seeing the default version I put there. No Borg at all is not reported for now, but should.

@m3nu m3nu added the type:enhancement Improvement of an existing function label Jul 22, 2019
@m3nu m3nu changed the title Vorta should not show wrong borg version - if borg is not installed Alert on missing Borg binary instead of showing placeholder version number Jul 22, 2019
@m3nu m3nu self-assigned this May 29, 2020
m3nu added a commit to m3nu/vorta that referenced this issue Jun 1, 2020
@m3nu
Add error message when Borg binary is missing. Fixes borgbase#333
973d46c
@m3nu
Copy link
Contributor

m3nu commented Jun 1, 2020

Added a simple notification for this.

Screen Shot 2020-06-01 at 12 47 20

@m3nu m3nu mentioned this issue Jun 1, 2020
Merged
@m3nu m3nu closed this as completed in 09b697e Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m3nu m3nu

Labels
type:enhancement Improvement of an existing function
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m3nu @goebbe