Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Exclude patterns GUI improvements #399

Closed
geckolinux opened this issue Jan 21, 2020 · 5 comments
Closed

Suggestion: Exclude patterns GUI improvements #399

geckolinux opened this issue Jan 21, 2020 · 5 comments
Labels
help wanted This issue is available, comment if you want to fix it status:planning For large features, plan it out before implementation type:feature New functionality

Comments

@geckolinux
Copy link

First of all, many thanks for Vorta, this is an extremely important tool to motivate less technical people to take advantage of the all the goodness of Borg.

The only part of the GUI that I found slightly confusing was the exclude patterns, especially after reading the link to the manual, which for a non-technical user doesn't explain clearly what exclude patterns are for or how to use them and how they differ from the other apparently similar methods for excluding certain files and/or directories from backups.

I think it would be nice for Vorta to have a few GUI exclusion improvements, while still allowing to manually type in patterns for experts who prefer that. Maybe something like:

  1. A field with directories and files to be excluded, basically the inverse of the Source Folders and Files to Back Up pane. This will probably cover 95% of beginners' needs.
  2. A checkbox to exclude folders with the .nobackup file.
  3. A GUI way of building slightly more complex exclusion rules, similar to buildregex.com , but obviously not as comprehensive, just to cover the most common rules of files and/or directories that start with BLAH, that containBLAH anywhere in the name, or end with BLAH, with a little additional help on the use of wildcards.

Thanks a lot!

@m3nu
Copy link
Contributor

m3nu commented Jan 22, 2020

I like the checkbox idea, item 2.

We probably don't have the resources to build item 3, but I'd like to have some examples for different OS.

Item 1 would be a list of absolute paths. Also possible, I think.

@m3nu m3nu added help wanted This issue is available, comment if you want to fix it status:planning For large features, plan it out before implementation type:feature New functionality labels Jan 22, 2020
@m3nu
Copy link
Contributor

m3nu commented Feb 9, 2020

Just noticed that Nextcloud (desktop client) comes with a nice list of default exclusions. Maybe something for Vorta to assimilate.

I agree that one simple kind of patterns would be enough.

@m3nu m3nu self-assigned this Feb 9, 2020
@m3nu m3nu removed their assignment Mar 1, 2020
@m3nu
Copy link
Contributor

m3nu commented Mar 3, 2020

Found some more details on macOS exclusions. They work via extended attributes. I think excluding those should be implemented in Borg directly. It already processes xattrs.

https://apple.stackexchange.com/questions/25779/on-os-x-what-files-are-excluded-by-rule-from-a-time-machine-backup

@mauromol
Copy link

mauromol commented Dec 20, 2020

I also found the exclusions part of the GUI quite confusing.

First of all, it's not really clear what type of exclusion syntax should I use there: the link to documentation sends to borg documentation where ALL exclusion syntaxes are explained. So, it's not clear whether I should assume Vorta passes my exclusion rules as -e/--exclude/--exclude-from or as --pattern/--patterns-from, so whether default style is fm: or rather sh: for instance.

Partly because of this and partly because of borg itself, if I add "/home/user/mauro" as source and I specify "cache" as an exclusion rule, I would expect "/home/user/mauro/cache" to be excluded (that is: "cache" being relative to the source), but it's not the case, I must specify "/home/user/mauro/cache". As I said, this is not completely Vorta's fault, however I think that a good way to workaround this would be to provide a preview button and dialog where I can see which files will be excluded based on my current rules. I don't know if this can be done by issuing a "borg create" command with --dry-run and proper logging settings: it would be extremely useful for me!

Just an additional note: this would be even more useful due to the fact that if you proceed by trial-and-error instead, the cancel button often makes Vorta freeze due to #332 😜

@m3nu
Copy link
Contributor

m3nu commented Dec 21, 2020

Yeah, this tab will be redone eventually.

In the meanwhile feel free to suggest new concepts or screenshots that could be useful here. I.e. to make Borg's different exclusion options accessible from a GUI.

@m3nu m3nu closed this as completed Feb 15, 2021
@borgbase borgbase locked and limited conversation to collaborators Feb 15, 2021
@borgbase borgbase unlocked this conversation Mar 2, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
help wanted This issue is available, comment if you want to fix it status:planning For large features, plan it out before implementation type:feature New functionality
Projects
None yet
Development

No branches or pull requests

3 participants