Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen platformdirs dependency #1843

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

stefanor
Copy link
Contributor

4.x is backwards compatible with 3.x except that site_cache_dir has moved to /var/cache. Vorta doesn't use this.

https://github.com/platformdirs/platformdirs/releases/tag/4.0.0

Related Issue

N/A

Motivation and Context

Debian is applying this patch so it can carry platformdirs 4.

How Has This Been Tested?

Ran the test suite as part of a Debian build.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

4.x is backwards compatible with 3.x except that site_cache_dir has
moved to /var/cache. Vorta doesn't use this.

https://github.com/platformdirs/platformdirs/releases/tag/4.0.0
@Hofer-Julian
Copy link
Collaborator

Seems like this change broke the macOS CI.
Maybe we adapt only the linux version range?

@m3nu
Copy link
Contributor

m3nu commented Nov 14, 2023

macos tests are currently timing out. It's not related to this PR. I still need to look into it.

@Hofer-Julian
Copy link
Collaborator

@m3nu do you plan to override the "required statuses must pass before merging" then?

@m3nu m3nu merged commit 98b6462 into borgbase:master Nov 14, 2023
7 of 11 checks passed
@m3nu
Copy link
Contributor

m3nu commented Nov 14, 2023

god mode 🙌

@stefanor stefanor deleted the platformdirs-4 branch November 14, 2023 16:13
@m3nu m3nu mentioned this pull request Nov 14, 2023
2 tasks
@m3nu
Copy link
Contributor

m3nu commented Nov 16, 2023

Took some screenshots for macOS CI tests. The tests run simply extremely slow and can't even get close to finishing in 20min. Hence the timeout.

Let's hope this is a temporary Github issue.

I've removed those tests from merge checks for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants