Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GUI II (without exclude-if-present) #1846

Merged
merged 36 commits into from Nov 24, 2023
Merged

Conversation

m3nu
Copy link
Contributor

@m3nu m3nu commented Nov 16, 2023

Continues #1742 with original scope only.

All based on @diivi work, who couldn't finish this GSoC subproject.

@m3nu
Copy link
Contributor Author

m3nu commented Nov 16, 2023

Removed the "Exclude if present" and only left the new Exclusion dialog.

Screenshot 2023-11-16 at 14 06 12

@diivi
Copy link
Contributor

diivi commented Nov 16, 2023

Hey, thanks! I'm out for Diwali holidays so I couldn't get back to you. Happy to see this move forward though. I'll try to help with the exclude if present dialog in the future.

@m3nu m3nu force-pushed the exclude-gui-2 branch 2 times, most recently from 6eddd35 to 12d0df4 Compare November 16, 2023 16:23
@m3nu
Copy link
Contributor Author

m3nu commented Nov 16, 2023

Just a few final edits here. If anyone has time for testing, that would be great and speed up the next beta release.

  • Only load exclusion presets for current OS (using the tags already there)
  • Keep expanding home folder for exclusions.
  • Build exclusions when running a backup instead of caching them when editing settings only.
  • Remove unnecessary DB migrations
  • Wasn't possible to add the same exclusion to multiple profiles.

@m3nu m3nu marked this pull request as ready for review November 19, 2023 12:44
@m3nu
Copy link
Contributor Author

m3nu commented Nov 21, 2023

Upon thinking about it, it may be better to have an internal ID/slug for each exclusion preset and not the name. Since we may want to change or translate the name later.

If there are no more change suggestions, I'll merge this and do another beta, Since it seems hard to get any testing of a PR right now.

@real-yfprojects
Copy link
Collaborator

I'll have a look tomorrow

Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with dropping the exclude-if-present widget is that its contents still apply although the user is neither aware of it nor can he edit those entries.

The rest looks good and seems to be working.

src/vorta/assets/exclusion_presets/browsers.json Outdated Show resolved Hide resolved
src/vorta/store/models.py Outdated Show resolved Hide resolved
src/vorta/views/exclude_dialog.py Outdated Show resolved Hide resolved
.coverage.nyx2.66373.469600 Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@m3nu
Copy link
Contributor Author

m3nu commented Nov 23, 2023

The issue with dropping the exclude-if-present widget is that its contents still apply although the user is neither aware of it nor can he edit those entries.

The rest looks good and seems to be working.

Thanks for looking into this! I've also disabled processing this setting by Borg. Until we may add it back in some other way.

@real-yfprojects
Copy link
Collaborator

MacOS tests seem to work again 🎉

@m3nu m3nu merged commit b502fc3 into borgbase:master Nov 24, 2023
9 of 11 checks passed
@m3nu m3nu mentioned this pull request Nov 24, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants