Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Compaction Scheduling #1981

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shivansh02
Copy link
Collaborator

@shivansh02 shivansh02 commented Apr 5, 2024

Description

Allows users to run borg compact after specified intervals. Added 2 columns to the profile model: compaction_on to check/uncheck scheduling, and compaction_weeks to set interval in weeks. Default interval set to 3 weeks.

Related Issue

Resolves #1718

Motivation and Context

Backup space usage is exploding for some people until they realize they have to run compact manually. This allows users to schedule running compact just like validation.

How Has This Been Tested?

Tested manually by setting compaction_cutoff to minutes instead of days in scheduler.py.

Screenshots (if appropriate):

Screenshot from 2024-04-05 14-04-56
Screenshot from 2024-04-05 14-09-33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@shivansh02 shivansh02 changed the title Compaction Scheduling WIP: Compaction Scheduling Apr 5, 2024
Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition!

src/vorta/store/migrations.py Show resolved Hide resolved
src/vorta/scheduler.py Outdated Show resolved Hide resolved
@shivansh02
Copy link
Collaborator Author

@m3nu All checks passed, can we merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: compacting schedule like we do for pruning
2 participants