Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount option override checkbox #682

Merged
merged 6 commits into from
Feb 18, 2021
Merged

Add mount option override checkbox #682

merged 6 commits into from
Feb 18, 2021

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Oct 7, 2020

Replaces #522, fixes #520

@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #682 (5be3279) into master (9a4bbf0) will decrease coverage by 3.18%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   73.35%   70.16%   -3.19%     
==========================================
  Files          55       55              
  Lines        3715     3720       +5     
==========================================
- Hits         2725     2610     -115     
- Misses        990     1110     +120     
Impacted Files Coverage Δ
src/vorta/models.py 80.19% <ø> (-0.50%) ⬇️
src/vorta/borg/mount.py 85.00% <83.33%> (-1.67%) ⬇️
src/vorta/keyring/kwallet.py 0.00% <0.00%> (-57.15%) ⬇️
src/vorta/autostart.py 45.45% <0.00%> (-51.52%) ⬇️
src/vorta/keyring/abc.py 51.42% <0.00%> (-37.15%) ⬇️
src/vorta/keyring/secretstorage.py 0.00% <0.00%> (-36.85%) ⬇️
src/vorta/notifications.py 50.00% <0.00%> (-34.85%) ⬇️
src/vorta/keyring/db.py 66.66% <0.00%> (-33.34%) ⬇️
src/vorta/network_status/abc.py 64.70% <0.00%> (-23.53%) ⬇️
src/vorta/network_status/network_manager.py 64.75% <0.00%> (-9.02%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4bbf0...5be3279. Read the comment docs.

@m3nu m3nu self-requested a review December 15, 2020 09:29
@m3nu m3nu self-assigned this Dec 15, 2020
src/vorta/assets/UI/archivetab.ui Outdated Show resolved Hide resolved
@samuel-w samuel-w marked this pull request as draft December 16, 2020 03:48
@samuel-w samuel-w marked this pull request as ready for review December 16, 2020 08:42
@m3nu m3nu removed their assignment Jan 19, 2021
@m3nu
Copy link
Contributor

m3nu commented Feb 18, 2021

Minor nitpick: I prefer to have this option in the misc tab. Why?

  • I doesn't clutter the archive tab.
  • Not used often.
  • If it's used, I may use it for multiple profiles (e.g. if I often restore data from NAS backups)
  • No need to pass new options around.

@samuel-w
Copy link
Contributor Author

Seems reasonable.

@m3nu m3nu merged commit 95d964c into borgbase:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use different permissions when mounting archive.
3 participants