Updating compliance tests to use prune-unused OPA compiler flag
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, yeah definitely looks like something like that is going on. Would have expected ~70 tests to be added, but the diff is only +9 from before 🤔 We could of course just compile with the prune flag where the plan otherwise comes back as main test/compliance |
|
Forgot to mention 😄 : the 62 missing tests are because of eval failures when running OPA to generate the baseline. Will look into those separately. |
|
Ah, interesting! Do let me know what you find 🤓 |
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
johanfylling
force-pushed
the
test/compliance
branch
from
b922705
to
e50f53d
Compare
|
Lots of failing tests to figure out 😅 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Need to figure out if use of this flag has negative impact on test coverage
Partially fixes #110
Signed-off-by: Johan Fylling johan.dev@fylling.se