Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline check before triangulation #205

Open
ayushbaid opened this issue Jun 30, 2021 · 2 comments
Open

Add baseline check before triangulation #205

ayushbaid opened this issue Jun 30, 2021 · 2 comments
Assignees
Labels
objective High level tasks to be accomplished

Comments

@ayushbaid
Copy link
Contributor

COLMAP checks the angle of the rays used in triangulation and rejects them if it is too low.

I wrote a unit test which confirms the behavior of failures due to small baseline when there is a 2px error in the measurements (quite common scenario).

We need to add this check in the data association pipeline.

@ayushbaid ayushbaid self-assigned this Jun 30, 2021
@ayushbaid ayushbaid linked a pull request Jul 7, 2021 that will close this issue
@akshay-krishnan
Copy link
Collaborator

The PR was not merged because metrics showed no improvements. I think this check must be done and we must investigate why it does not make any difference. Maybe we will discover other issues.

@akshay-krishnan
Copy link
Collaborator

Its possible our tracks already have a good triangulation angle, in which case this check still makes sense for datasets we would use in the future.

@akshay-krishnan akshay-krishnan added the objective High level tasks to be accomplished label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
objective High level tasks to be accomplished
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants