Fix issue when using both --dry-run and -v options #21
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! I'll go ahead and add some tests separately. By the way, this issue does not appear to manifest in Borg 1.1.2, but does in Borg 1.1.4. So it must've been something introduced relatively recently. |
|
It seems --dry-run was made incompatible with --stats in Borg 1.1.3. See Issue #3298. |
|
This has been released as part of borgmatic 1.1.15! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to do a backup with both
--dry-runand verbosity (either-v 1or-v 2) set, I encountered the following error:This pull request is a pretty quick and dirty fix.
Should probably also add some unit tests that have both verbosity and dry-run set.