Support node12 and goodies #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disclamer, I made repl-story as replacement for repl.history that does now support new repl APIs
|
@AdrieanKhisbe Thank you for the contribution! That’s a lot indeed. Will take some time until I have reviewed it all, but I’ll try to make some time soon. |
|
@AdrieanKhisbe Looks good. 👍Except for the table in README.md 😬Can you have a look? |
|
Hello @borisdiakur :) That was quick! Indeed, I should have had a look 😁 and not make it blindly 🙈 |
Seem like I had some old orgmode syntax habit 😁
|
et voilà, I'll put that blunder on old orgmode habits.
|
|
Thanks again @AdrieanKhisbe 🙏 |
|
Awesome @borisdiakur ! =) (Might come back one of these days if ever I resume my prototype about introducing lodash/fp signature doc from within the REPL 📖... 🤞) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr a set of enhancements that started with tackling issue of node 12 support (
Internal of REPLServer were reworked, breaking
repl.historydependency:[DEP0124] DeprecationWarning: REPLServer.rli is deprecated),and escalated quickly into a lot of different features and refactors:
repl.historyto support node12yargsto help with flag parsing (and configuration via env vars).lodashrepl command (see doc introduced in README)=)