Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone 6S+ DPDB Problem #146

Open
devasur opened this issue Jun 20, 2016 · 12 comments
Open

iPhone 6S+ DPDB Problem #146

devasur opened this issue Jun 20, 2016 · 12 comments

Comments

@devasur
Copy link

devasur commented Jun 20, 2016

Getting many reports on screen problems with iPhone 6S+. I have followed the last discussion on iPhone 6S @brianchirls . #102 . Can see that the device information that solved the original problem is there on https://storage.googleapis.com/cardboard-dpdb/dpdb.json (Which is getting used by webvr-polyfill). How should I solve this?

iphone_6s_screen_size

http://btco-code.appspot.com/debug/screen_test.html | RESULTS

Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13F69 Safari/601.1
computed resolution: 2208 x 1242
screen.width: 414
screen.height: 736
screen.availWidth: 414
screen.availHeight: 736
window.devicePixelRatio: 3

Example with problem : https://walkinto.in/vr/Zyp_MbAYHxZygpufbAFSe

@devasur devasur changed the title iPhone 6S+ / iPhone 6S | DPDB Problem iPhone 6S+ DPDB Problem Jun 20, 2016
@devasur
Copy link
Author

devasur commented Jun 20, 2016

Confirmed this is a problem only with 6S+

@elephantatwork
Copy link

We have the same issue and it's solved by setting BUFFERSCALE down to 0.5, but that results in a very lowres image, which looks very bad in comparison to other devices.

Also there is some white space underneath that sometime shows when you rotate the phone or have a click event.
img_0261

@elephantatwork
Copy link

And we have the issue on a iPhone 6 Model A1586.

@DylanNWatt
Copy link

Hey, just grabbed the repo to start messing around with webvr. Great stuff, really exciting. Wanted to confirm this on iphone 6 plus, model MGC2LL/A.
img_0441

@devasur
Copy link
Author

devasur commented Jul 17, 2016

This got fixed for us. Please check whether this link opens w/o problems : https://walkinto.in/vr/Zyp_MbAYHxZygpufbAFSe

Two things
(1) <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0"> (2) Added the device profile for iPhone 6 into the local version of dpdb

@borismus
Copy link
Owner

How did you fix the problem?

On Sat, Jul 16, 2016 at 7:08 PM Boni Gopalan notifications@github.com
wrote:

This got fixed for us. Please check whether this link opens w/o problems :
https://walkinto.in/vr/Zyp_MbAYHxZygpufbAFSe

Two things
(1)
(2) Added the device profile for iPhone 6 into the local version of dpdb


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#146 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQ8gEJQ_V3_vwVDbhd09bN7RKtjtjajks5qWY6UgaJpZM4I5Yxc
.

@corentin-begne
Copy link

@devasur can you share the solution pls I still have the pb

@devasur
Copy link
Author

devasur commented Oct 14, 2016

Edited webvr-polyfill.js to include device profile for iPhone 6S+
{
"type": "ios",
"rules": [ { "res": [ 1125, 2001 ] } ],
"dpi": [ 410.9, 415.4 ],
"bw": 4,
"ac": 1000
}
#102

This looked like an oversight during merge to me.

@borismus
Copy link
Owner

Is 6S any different from 6 in terms of display characteristics?
On Thu, Oct 13, 2016 at 10:13 PM Boni Gopalan notifications@github.com
wrote:

Edited webvr-polyfill.js to include device profile for iPhone 6S+
{
"type": "ios",
"rules": [ { "res": [ 1125, 2001 ] } ],
"dpi": [ 410.9, 415.4 ],
"bw": 4,
"ac": 1000
}
#102 #102

This looked like an oversight during merge to me.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#146 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQ8gB-KkTxc4ZqGwKLhN6KB5Lz3nuXrks5qzw9bgaJpZM4I5Yxc
.

@corentin-begne
Copy link

@devasur thx for you reply
@borismus can you update the webvr-polyfill to integrate this device profile pls ?

@borismus
Copy link
Owner

borismus commented Oct 21, 2016

DPDB already includes that entry: https://storage.googleapis.com/cardboard-dpdb/dpdb.json. What are you asking for?

@corentin-begne
Copy link

ok it seems to work now.
thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants