Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a way for the rotate instructions interstitial to announce its show/hide-ing #93

Closed
gmarinov opened this issue Apr 14, 2016 · 11 comments
Closed

Comments

@gmarinov
Copy link

e.g. document.body.dispatchEvent(new CustomEvent('VRInstructionsShown'))

@borismus
Copy link
Contributor

Why? How are the rotate instructions not desirable?

On Thu, Apr 14, 2016 at 12:23 PM Georgi Marinov notifications@github.com
wrote:

e.g. document.body.dispatchEvent(new CustomEvent('VRInstructionsShown'))


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#93

@gmarinov
Copy link
Author

it's desirable to sync to the interstitial becoming frontmost or hiding...

@kschzt
Copy link

kschzt commented Apr 20, 2016

@borismus it's not about desirability, this is just an event to know when it's shown / hidden

@borismus
Copy link
Contributor

This can be done, propose an event name, and we can emit it. This is already done for other events like onvrdisplaypresentchange

@gmarinov
Copy link
Author

gmarinov commented May 6, 2016

well, it's up there at the very top of the post. if it needs to be in all lowercase, then that would make it vrinstructionsshown, and its counterpart - vrinstructionshidden.

@borismus
Copy link
Contributor

borismus commented May 6, 2016

How about having the vrdisplaychange event fire after the instructions are
hidden?

On Fri, May 6, 2016 at 2:57 AM Georgi Marinov notifications@github.com
wrote:

well, it's up there at the very top of the post. if it needs to be in all
lowercase, then that would make it "vrinstructionsshown", and its
counterpart - "vrinstructionshidden".


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#93 (comment)

@gmarinov
Copy link
Author

gmarinov commented May 6, 2016

how would that address the 'shown' part?

@borismus
Copy link
Contributor

borismus commented May 6, 2016

It would not.

On Fri, May 6, 2016 at 8:40 AM Georgi Marinov notifications@github.com
wrote:

how would that address the 'shown' part?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#93 (comment)

@gmarinov
Copy link
Author

gmarinov commented May 6, 2016

so can we get a vrinstructionsshown and vrinstructionshidden then?

@borismus
Copy link
Contributor

borismus commented May 6, 2016

Sure, please submit a PR.

On Fri, May 6, 2016 at 8:51 AM Georgi Marinov notifications@github.com
wrote:

so can we get a vrinstructionsshown and vrinstructionshidden then?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#93 (comment)

@borismus
Copy link
Contributor

Out of scope. Polyfill needs to track WebVR spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants