-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a way for the rotate instructions interstitial to announce its show/hide-ing #93
Comments
Why? How are the rotate instructions not desirable? On Thu, Apr 14, 2016 at 12:23 PM Georgi Marinov notifications@github.com
|
it's desirable to sync to the interstitial becoming frontmost or hiding... |
@borismus it's not about desirability, this is just an event to know when it's shown / hidden |
This can be done, propose an event name, and we can emit it. This is already done for other events like |
well, it's up there at the very top of the post. if it needs to be in all lowercase, then that would make it |
How about having the vrdisplaychange event fire after the instructions are On Fri, May 6, 2016 at 2:57 AM Georgi Marinov notifications@github.com
|
how would that address the 'shown' part? |
It would not. On Fri, May 6, 2016 at 8:40 AM Georgi Marinov notifications@github.com
|
so can we get a |
Sure, please submit a PR. On Fri, May 6, 2016 at 8:51 AM Georgi Marinov notifications@github.com
|
Out of scope. Polyfill needs to track WebVR spec. |
e.g.
document.body.dispatchEvent(new CustomEvent('VRInstructionsShown'))
The text was updated successfully, but these errors were encountered: