🔐 ✨ Keys leakage & docker image update #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @linjan 👋 Thank you very much for opening this PR, which makes all the sense in the world 🙏 I'll merge it right away. Regards! |
borjapazr
approved these changes
Nov 23, 2023
borjapazr
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Thank you for noticing this. Although these secrets are test secrets, it is not correct to set them up this way and share them in the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Minor Mars Update 🔧
Greetings,
Please find below the recent changes delivered in this pull request:
🔒 Removed static Spotify secrets and replaced them with environment variables. Transparency of secrets is crucial for maintaining good security practices. ✅
🐳 Updated homepage Docker image name, in accordance with the official Github repository. It's always best to keep up with the official documentation to ensure stability, efficiency and security. ✅
Making us create better, safer and more robust systems. Looking forward to your review and comments.
Best regards,
linjan