Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the custom version support in command line args #598

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

pradeepbishnoi
Copy link
Contributor

Install the custom version or latest version of babashka using command line args

Install the custom version or latest version of babashka using command line args
@borkdude
Copy link
Collaborator

Thanks. Two questions:

  • Why the change for /tmp/bb instead of /usr/local/bin?
  • Does it still support the old way, i.e. only passing a directory name without flags?

@borkdude borkdude marked this pull request as draft September 25, 2020 15:48
Fixed the install path
@pradeepbishnoi
Copy link
Contributor Author

Resolved the default path, that tmp path was used while local testing.

@borkdude
Copy link
Collaborator

Thanks. The only thing left is to fix compatibility with the old way of using the script: install <dir> .

@borkdude borkdude marked this pull request as ready for review September 25, 2020 16:37
@borkdude borkdude merged commit d490536 into babashka:master Sep 25, 2020
@borkdude
Copy link
Collaborator

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants