Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please support NO_COLOR #70

Closed
sandrotosi opened this issue Jul 31, 2019 · 2 comments
Closed

please support NO_COLOR #70

sandrotosi opened this issue Jul 31, 2019 · 2 comments
Milestone
v6.0.0

Comments

@sandrotosi
Copy link

https://no-color.org/

it would be great if we can set this variable to control if colors are printed or not
@GhostofGoes
Copy link

If you want the feature, you should open a PR, as I doubt borntyping will have the time to tackle this anytime soon. Seems like it'd be simple to implement, just read from os.environ on init, set a flag, then check the flag when configuring a logger.

@borntyping borntyping added this to the v6.0.0 milestone Apr 13, 2021
borntyping added a commit that referenced this issue Apr 13, 2021
@borntyping
Support NO_COLOR environment variable, fixing #70
58f9204
@borntyping
Copy link
Owner

Support for NO_COLOR has been added in 6.0.0a2.

(This is a prerelease and may change before version 6.0.0.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
3 participants
@borntyping @sandrotosi @GhostofGoes