Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro init-by-env #12

Merged
merged 1 commit into from
Feb 25, 2020
Merged

macro init-by-env #12

merged 1 commit into from
Feb 25, 2020

Conversation

kindlychung
Copy link

A macro for simulating env_logger behavior, which enables the user to choose log level by setting a RUST_LOG environment variable.

@borntyping
Copy link
Owner

Does this need to be a macro? It looks like it could just be a function, but I might be missing something (I've not actively worked in rust for a while).

@kindlychung
Copy link
Author

It's been a while and I'm not sure what experiments I did back then, but I can look into it once I got some free time.

@kindlychung kindlychung mentioned this pull request Feb 24, 2020
@kindlychung
Copy link
Author

You are right indeed, it could be a function and I made a new pr in #13

@borntyping borntyping merged commit 7a9b67a into borntyping:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants