Add an option to control whether timestamps are to be printed or not. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creekorful
reviewed
Apr 28, 2021
| println!( | ||
| "{} {:<5} [{}] {}", | ||
| Local::now().format("%Y-%m-%d %H:%M:%S,%3f"), | ||
| level_string, | ||
| target, | ||
| record.args() | ||
| ); | ||
| return; |
There was a problem hiding this comment.
out of curiosity: why the return; instead of an else?
There was a problem hiding this comment.
To avoid duplicating the code for the two cases where there is no timestamp.
There was a problem hiding this comment.
Oh yes, forget the #[cfg(feature = "chrono")] just above.
| @@ -37,6 +41,7 @@ impl SimpleLogger { | |||
| SimpleLogger { | |||
| default_level: LevelFilter::Trace, | |||
| module_levels: Vec::new(), | |||
| timestamps: true | |||
There was a problem hiding this comment.
Sorry about that, I guess I have to figure out how to convince the Rust mode to use spaces instead of tabs.
There was a problem hiding this comment.
Does cargo fmt works for you?
|
Released in 1.12.0 with some changes (and a copy of this feature for colours, too). Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps are useful when debugging, but when the program is executed from systemd, journald automatically adds timestamps to the lines, so one gets duplicate timestamps.
This adds an option to turn timestamps off without having to recompile with a different feature set.