Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable timestamps format #79

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Customizable timestamps format #79

merged 4 commits into from
Mar 18, 2023

Conversation

ctaoist
Copy link
Contributor

@ctaoist ctaoist commented Mar 14, 2023

Added with_custom_timestamps to customize timestamps format.

borntyping
borntyping reviewed Mar 14, 2023
View reviewed changes
Copy link
Owner

@borntyping borntyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat and tidy. Any chance you could add an example in the examples/ directory?

src/lib.rs Outdated Show resolved Hide resolved
ctaoist and others added 2 commits March 15, 2023 09:07
@ctaoist @borntyping
Update src/lib.rs
c7ab668 
Co-authored-by: Sam Clements <sam@borntyping.co.uk>
@ctaoist
1. added examples/timestamps_format.rs
5998a66 
2. could customize format for utc timestamps
@ctaoist
Copy link
Contributor Author

ctaoist commented Mar 15, 2023

Added examples/timestamps_format.rs and could also customize format for utc timestamps now.

@borntyping
Copy link
Owner

Neat! I'll try and get this merged and released soon.

@borntyping borntyping merged commit c32992b into borntyping:main Mar 18, 2023
@borntyping
Copy link
Owner

Released as 4.1.0 with some minor changes - the only breaking one would be that with_custom_timestamps was renamed to with_timestamp_format. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borntyping borntyping borntyping left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctaoist @borntyping