Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Initialize simple logger with custom logging-backend. #85

Closed

Conversation

fslongjin
Copy link

Feature: Initialize simple logger with custom logging-backend.

@fslongjin
Copy link
Author

ping

@borntyping
Copy link
Owner

borntyping commented Nov 13, 2023

I'm very conflicted on this PR - it's cleanly implemented and well documented, but it isn't something I want to include in a logging library that aims to be very simple (and low-effort to maintain) so I don't plan to merge it. Thank you for your efforts anyway!

(More specifically, simple_logger is already a logging backend for the log library, and makes a lot of choices that make it very specific to terminal output that wouldn't make sense for any other backend like files or external services. If you're partically intrested in using the output format in another backend, splitting the text formatting out from printing so it could be called from another library might make sense. Or if this is something you have plans to expand on, I absolutely endorse forking it and using it as a base to build on.)

@borntyping borntyping closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants