Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misguided env_logger reference from docs #87

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Remove misguided env_logger reference from docs #87

merged 1 commit into from
Nov 23, 2023

Conversation

igortg
Copy link
Contributor

@igortg igortg commented Nov 16, 2023

Remove env_logger reference from env() method docs to avoid confusion since simple_logger does not fully support the same syntax from env_logger to on parsing RUST_LOG env var.

Fix #75

@borntyping
Copy link
Owner

Looks good, will try and find some time to fix the lint issues and merge it soon. Thanks!

Remove env_logger reference from env() method docs to avoid
confusion since simple_logger does not fully support the same
syntax from env_logger to on parsing RUST_LOG env var.

Fix #75
@borntyping borntyping merged commit 7283faa into borntyping:main Nov 23, 2023
13 of 14 checks passed
@borntyping
Copy link
Owner

Released as part of 4.3.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleLogger::env doesn't (fully) simulate env_logger
2 participants