Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when I include a newline in the name? #4

Closed
wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

No description provided.

@notriddle
Copy link
Contributor Author

bors r+

1 similar comment
@notriddle
Copy link
Contributor Author

bors r+

@notriddle
Copy link
Contributor Author

Like I figured. It logs a crash, because GitHub doesn't allow newlines in the committer name.

{{:badmatch, {:error, :synthesize_commit}},
 [{BorsNG.GitHub, :synthesize_commit!, 2,
   [file: 'lib/github/github.ex', line: 90]},
  {BorsNG.Worker.Batcher, :start_waiting_merged_batch, 4,
   [file: 'lib/worker/batcher.ex', line: 297]},
  {BorsNG.Worker.Batcher, :start_waiting_batch, 1,
   [file: 'lib/worker/batcher.ex', line: 271]},
  {BorsNG.Worker.Batcher, :poll, 1,
   [file: 'lib/worker/batcher.ex', line: 200]},
  {BorsNG.Worker.Batcher, :handle_info, 2,
   [file: 'lib/worker/batcher.ex', line: 182]},
  {:gen_server, :try_dispatch, 4,
   [file: 'gen_server.erl', line: 616]},
  {:gen_server, :handle_msg, 6,
   [file: 'gen_server.erl', line: 686]},
  {:proc_lib, :init_p_do_apply, 3,
   [file: 'proc_lib.erl', line: 247]}]}

@notriddle notriddle closed this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant