This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Add PUBLIC_PROTOCOL to allow serving from a HTTP endpoint #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened RFC here for discussion: https://forum.bors.tech/t/rfc-add-a-new-environment-variable-public-protocol-to-allow-serving-bors-at-a-http-endpoint/521 |
|
@notriddle the linked RFC has been open for 2 weeks, currently there has been no feedback. Are you open to merging as this is a back-compatible change and there have been no objections? |
|
@notriddle the associated RFC has closed with no further comments. Is this okay to merge? |
|
Yeah, it is. bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 5, 2020
1043: Add PUBLIC_PROTOCOL to allow serving from a HTTP endpoint r=notriddle a=tommilligan Closes #1042 This PR introduces a new environment variable, `PUBLIC_PROTOCOL`. If unset, the value defaults to the current hardcoded value of `https`, with no change in behaviour: ```log 13:46:22.316 pid=<0.2038.0> [info] Running BorsNG.Endpoint with cowboy 1.1.2 at 0.0.0.0:39103 (http) 13:46:22.318 pid=<0.2005.0> [info] Access BorsNG.Endpoint at https://172.17.0.1:39103 ``` If `PUBLIC_PROTOCOL=http` is set, the endpoint is updated accordingly: ```log 13:48:59.885 pid=<0.2038.0> [info] Running BorsNG.Endpoint with cowboy 1.1.2 at 0.0.0.0:39103 (http) 13:48:59.887 pid=<0.2005.0> [info] Access BorsNG.Endpoint at http://172.17.0.1:39103 ``` This allows the app to run at a HTTP endpoint if HTTPS is not required. Co-authored-by: Tom Milligan <tom@reinfer.io>
|
Build failed:
|
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1042
This PR introduces a new environment variable,
PUBLIC_PROTOCOL. If unset, the value defaults to the current hardcoded value ofhttps, with no change in behaviour:If
PUBLIC_PROTOCOL=httpis set, the endpoint is updated accordingly:This allows the app to run at a HTTP endpoint if HTTPS is not required.