This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Ignoring review entries without commit_id #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notriddle
approved these changes
Nov 30, 2021
|
Build succeeded: |
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Dec 1, 2021
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Dec 1, 2021
Add @gfleury to new contributors list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Enterprise latest versions has more review types, some of them do not have commit_id node, and of course this is causing it to fail.
The test added cover the types of reviews available.