This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Do not update base branches if the branch could not be deleted #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After someone made a PR from `master` to `random-branch`, bors tried to delete our master branch (which failed), but then re-targeted 200 of our open PRs against some random branch! In this scenario, the branch deletion is forbidden by github; the intent in this change is to use this as a signal to not proceed with the re-targeting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After someone made a PR from
mastertorandom-branch, bors tried to delete our master branch (which failed), but then re-targeted 200 of our open PRs against some random branch!In this scenario, the branch deletion is forbidden by github; the intent in this change is to use this as a signal to not proceed with the re-targeting.
I'm working on the assumption that
.delete_branch!throws an exception if it fails, but I'm not familiar with the language.I understand that bors is EOL and so you might not want to spend time reviewing this.