fix(css): processPath should return path to file
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blond
force-pushed
the
fix/css-path-process
branch
from
a96fb36
to
95d7f04
Compare
|
LGTM |
rndD
approved these changes
Oct 25, 2016
| @@ -56,7 +58,7 @@ exports.Tech = base.Tech.inherit({ | |||
| range: [m.index, allRe.lastIndex - 1] | |||
| }); | |||
| } else if (srcStringRx.test(m[0])) { | |||
| // src=... | |||
| // src=... | |||
There was a problem hiding this comment.
Хотя нет, он полезный.
Это про то, во что превратится файл после обработки. В url(...) или src=....
There was a problem hiding this comment.
Ну он полезный. Но лучше сделать его чуть более понятным.
The correct path to the file is needed to read or obtain stats. Before changes the `processPath` method deletes `?` symbol, but not query part. **Example:** ``` pathname?x=1 ``` **Result before changes:** ``` pathnamex=1 ``` **Result after changes:** ``` path ``` The same method did not remove the `hash` part: **Example:** ``` path#hash ``` **Result before changes:** ``` path#hash ``` **Result after changes:** ``` path ```
blond
force-pushed
the
fix/css-path-process
branch
from
95d7f04
to
5cddf05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct path to the file is needed to read or obtain stats.
Before changes the
processPathmethod deletes?symbol, but notquery part.
Example:
Result before changes:
Result after changes:
The same method did not remove the
hashpart:Example:
Result before changes:
Result after changes:
processPathwas added in 4267461 commit to: