Fixed tab grouping broken under Vivaldi 5.3 #11
Conversation
grigorye
changed the title
There was a problem hiding this comment.
I've been using this patch for over a week now and it seems to work fine.
In addition to the grouping, this appears to resolve #7 as well.
The change is a straightforward reference update.
My only gripe is that I can't seem to find documentation for Vivaldi's extension API, which I assume is not publicized.
Given that this change works, it's reasonable to assume this is the correct reference name (at least at this time).
I have no influence on this repo but can give a Works on my machine™ seal of approval if that's useful to the maintainer. And big thanks to both authors (patch and original extension).
|
I'd also like to confirm that this works reliably and as expected within Vivaldi. Thank you for submitting this. |
|
Thanks for this fix 🙏 |
Loading this extension as-is throws a warning about v2's deprecation. This is in preparation for: https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/ Following: https://developer.chrome.com/docs/extensions/mv3/mv3-migration/#man-sw The extension's version number should probably be incremented as well. (Either in this commit or one directly following it.) I'm running this on Vivalid and it seems to work (when on top of #11), but otherwise this is not extensively tested. *** Extra note: It doesn't seem required, but it might be better to move `background.js`'s content to another file. Then change `bacground.js` to something that looks like the (now deleted) `background.html` page, except using `importScripts` instead of `<script>` tags. As-is, `background.ts` seems to import `./tabs_helpers.js` anyway/explicitly so it doesn't seem to make a difference when iusing `"type": "module"`. Co-authored-by: Benjamin Orsini <github.o7tgl@simplelogin.com>
Starting with at least Vivaldi 5.3.2679.51, grouping functionality no longer works correctly. From what I could figure out while debugging, the code no longer runs Vivaldi-specific paths, as
extDatais no longer part of the tab objects.Still, there's
vivExtData, that looks like a new name for the same field:This PR adjusts the code for the new field name, and from what I can see, as result, the grouping functionality is working fine again.