Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong listing of fields in field table caused by last commit #21

Closed
wants to merge 1 commit into from

Conversation

danieldreke
Copy link
Contributor

@danieldreke danieldreke commented Apr 2, 2020

My last commit caused a bug :(
The listed fields in field table are for certain cases wrong.
The changes in this commit seem to fix it for my scenario, but haven't checked other scenarios.
If you don't have to time to check, please undo my last pull request.
If you have time to check and if this commit fixes it, please pull.
Thank you.

@borysiasty
Copy link
Owner

borysiasty commented Apr 5, 2020

Hi, I reverted that last commit right after merging it. Did you read my comment there?

Your approach works fine with rasters. But for vectors it reorders fields and mixes fields from different layers. So I'd order input layers rather than fields.

But in general I strongly recommend switching to the 'Sample Raster Values' processing algorithm. I only keep this plugin alive because of lack of such algorithm for sampling vectors.

@borysiasty borysiasty closed this Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants