Encode RealFloat numbers using Scientific.fromFloatDigits #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code used realToFrac (fromRation . toRational) which approximates a floating point value. For example: > toRational (1.2::Double) 5404319552844595 % 4503599627370496 If you encode this Rational number to a Scientific number and render it you get: > encode (1.2::Double) "1.1999999999999999555910790149937383830547332763671875" Using Scientific.fromFloatDigits you get the expected: > encode (1.2::Double) "1.2"
bos
added a commit
that referenced
this pull request
Nov 19, 2013
Encode RealFloat numbers using Scientific.fromFloatDigits
tolysz
pushed a commit
to tolysz/aeson
that referenced
this pull request
May 18, 2015
Encode RealFloat numbers using Scientific.fromFloatDigits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code used realToFrac (fromRational . toRational) which approximates a floating point value. For example:
If you encode this Rational number to a Scientific number and render it you get:
Using
Scientific.fromFloatDigitsyou get the expected: