Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct with appropriate words #14

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Correct with appropriate words #14

merged 1 commit into from
Sep 6, 2022

Conversation

Kang-Simon
Copy link
Contributor

@Kang-Simon Kang-Simon commented Sep 5, 2022 •
edited
Loading

json file is not subject to review.

@Kang-Simon Kang-Simon changed the title modify_words Correct with appropriate words Sep 5, 2022
TrustHenry
TrustHenry reviewed Sep 5, 2022
View reviewed changes
src/Routes.tsx Outdated Show resolved Hide resolved
MichaelKim20
MichaelKim20 requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@MichaelKim20 MichaelKim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

샤딩에 대한 정책은 다른 이슈에서 다시 다룹시다

src/pages/Acknowledgements/pageContent.tsx Show resolved Hide resolved
src/pages/Checklist/index.tsx Outdated Show resolved Hide resolved
src/pages/Checklist/index.tsx Outdated Show resolved Hide resolved
src/pages/Checklist/index.tsx Show resolved Hide resolved
@Kang-Simon Kang-Simon mentioned this pull request Sep 6, 2022
Closed
MichaelKim20
MichaelKim20 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@MichaelKim20 MichaelKim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kang-Simon Kang-Simon mentioned this pull request Sep 6, 2022
Closed
TrustHenry
TrustHenry approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@TrustHenry TrustHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrustHenry TrustHenry merged commit 80b4bb7 into bosagora:agora Sep 6, 2022
@Kang-Simon Kang-Simon deleted the modify_words branch September 19, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKim20 MichaelKim20 MichaelKim20 approved these changes

@TrustHenry TrustHenry TrustHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kang-Simon @MichaelKim20 @TrustHenry