Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal pre-images on a timer #582

Closed
Geod24 opened this issue Feb 24, 2020 · 0 comments
Closed

Reveal pre-images on a timer #582

Geod24 opened this issue Feb 24, 2020 · 0 comments
Assignees
@TrustHenry
Labels
Story-Points:5 This takes 3 to 5 days to complete type-enhancement An improvement of existing functionalities
Milestone
2. Validator

Comments

@Geod24
Copy link
Collaborator

Geod24 commented Feb 24, 2020

Instead of having pre-image reveal happening on putTransaction, it should be done via a timer.
Currently this is done here: https://github.com/bpfkorea/agora/blob/0cdc928b09eddec41f78a2c1a36459dac532a9c6/source/agora/node/Node.d#L252-L260

This can be trivially done via Vibe.d's setTimer function.
It is currently not implemented in LocalRest, but since we have non-blocking sleep and runTask as primitives, it should be trivial to implement it.
@Geod24 Geod24 added the type-enhancement An improvement of existing functionalities label Feb 24, 2020
@Geod24 Geod24 added this to the 2. Validator milestone Feb 25, 2020
@Geod24 Geod24 mentioned this issue Feb 28, 2020
Merged
@bpalaggi bpalaggi assigned TrustHenry and unassigned linked0 May 19, 2020
@bpalaggi bpalaggi added the Story-Points:5 This takes 3 to 5 days to complete label May 20, 2020
@TrustHenry TrustHenry mentioned this issue May 20, 2020
Merged
@Geod24 Geod24 closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrustHenry TrustHenry

Labels
Story-Points:5 This takes 3 to 5 days to complete type-enhancement An improvement of existing functionalities
Projects
None yet
Milestone
2. Validator
Development

No branches or pull requests
4 participants
@Geod24 @linked0 @TrustHenry @bpalaggi