-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement request timeouts in unittests #119
Conversation
2d67d19
to
8d6fdf5
Compare
Unblocked. |
source/agora/test/NetworkClient.d
Outdated
unittest | ||
{ | ||
import vibe.core.log; | ||
import core.thread; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How dare you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the ordering. But actually the vibe
import is a debug one, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always ordered them like this:
- local imports first
- dependencies second
- core/std imports after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah the style guide says
Imports are organized by packages: agora first, dependencies second, std third, core last.
Ok, I will move the core import last.
Ugh.. failures. |
Failure was unrelated, some package failed to download. |
It passes now. |
Sadness. Anyway, ready to merge? |
8d6fdf5
to
0a88770
Compare
b6a9736
to
5ff42f4
Compare
Ah I think I know what's wrong. It's the logic in my code. I have a But it's not taking into account the time it takes for the request to time-out. So the actual time spent is:
I need to take this into account.. at least in my unittests. |
f6a8cc0
to
2bf3373
Compare
962c9e7
to
fa389f0
Compare
It seems like Travis does some kind of dependency caching.. because it's not finding the localrest commit in my branch, even though it's there (I did update .gitmodules too). |
9bcf439
to
ee4371d
Compare
Ping. |
ee4371d
to
051ad5c
Compare
Re-ordered imports. |
051ad5c
to
8327d16
Compare
Fixed. |
Still red |
Great. Can we drop Mac support? |
This adds support for request timeouts
This uses LocalRest's support for request timeouts, but doesn't yet use vibe.d's request timeouts as they haven't been implemented yet.
8327d16
to
3ef8b98
Compare
Blocked by dependencies. The support code in the node is pretty simple though. And a unittest is included (which passes with all dependencies).
Requires:
The vibe.d support has not been implemented yet.