-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rudimentary bindings to std::unordered_map #662
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.x.x #662 +/- ##
==========================================
+ Coverage 90.97% 91.01% +0.03%
==========================================
Files 63 63
Lines 4754 4761 +7
==========================================
+ Hits 4325 4333 +8
+ Misses 429 428 -1
Continue to review full report at Codecov.
|
Can you paste the linking error ? Probably some bad mangling of the return value. EDIT: 🤦♂ |
It's in the PR description no? |
|
6a02124
to
6524b2c
Compare
I added |
@AndrejMitrovic : Yes please. The bug is very simple once you look at the mangling:
|
6524b2c
to
4bbe009
Compare
Filed https://issues.dlang.org/show_bug.cgi?id=20679 and referenced it in the comments. |
4bbe009
to
4cb30c9
Compare
Had to continue using Otherwise it's ready. |
4cb30c9
to
f22f6a5
Compare
Rebased against master, green. |
|
f22f6a5
to
bac693d
Compare
Bad rebase, fixed.
Sure, I'll fix it up tomorrow. |
It's used heavily in the quorum intersection checker code which will be binded to soon.
bac693d
to
9c0db4b
Compare
Replaced some pointers with |
@Geod24 there seems to be a linking issue when I change
cpp_unordered_map_create
to return a proper type rather than just avoid*
. See all the// todo
comments.